Skip to content

Conversation

@MayorFaj
Copy link

@MayorFaj MayorFaj commented Dec 5, 2025

Checklist

Ensure you have completed the following checklist for your pull request to be reviewed:

  • Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
    commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
    the sign-off email address. See CONTRIBUTING.md
    for more information.
  • Referenced issues using Fixes: #27691 in commit message (if applicable)
  • Tests have been added/updated (or no tests are needed)
  • Documentation has been updated (or no documentation changes are needed)
  • All commits pass make validatepr (format/lint checks)
  • Release note entered in the section below (or None if no user-facing changes)

Does this PR introduce a user-facing change?

None

Fixes #27691
This pull request updates the timestamp formatting in container logs to provide higher precision.

  • Logging improvement:
    • In pkg/api/handlers/compat/containers_logs.go, the timestamp format for log entries was changed from time.RFC3339 to time.RFC3339Nano, allowing log timestamps to include nanosecond precision.

Signed-off-by: MayorFaj <mayorfaj@gmail.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MayorFaj
Once this PR has been reviewed and has the lgtm label, please assign lsm5 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot added the kind/api-change Change to remote API; merits scrutiny label Dec 5, 2025
@MayorFaj MayorFaj marked this pull request as draft December 6, 2025 11:42
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 6, 2025
Signed-off-by: MayorFaj <mayorfaj@gmail.com>
@MayorFaj MayorFaj marked this pull request as ready for review December 6, 2025 12:18
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 6, 2025
Signed-off-by: MayorFaj <mayorfaj@gmail.com>
@MayorFaj MayorFaj force-pushed the fix-logs-timestamp-precision branch from e1e955d to e28d1e5 Compare December 6, 2025 13:10
@MayorFaj MayorFaj marked this pull request as draft December 6, 2025 13:40
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 6, 2025
@MayorFaj MayorFaj marked this pull request as ready for review December 6, 2025 13:40
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 6, 2025
@baude
Copy link
Member

baude commented Dec 6, 2025

if we are following docker behavior, then its likely not a bug. else, LGTM at quick glance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/api-change Change to remote API; merits scrutiny release-note-none

Projects

None yet

Development

Successfully merging this pull request may close these issues.

container logs timestamp precision differs in web service vs local

2 participants