feat: Upgrade to Node 22 #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjermanovic
approved these changes
Jan 15, 2025
Member
mdjermanovic
left a comment
mdjermanovic
left a comment
There was a problem hiding this comment.
LGTM, thanks! Leaving it open if anyone else wants to take a look, or feel free to merge when appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant updates to dependencies, refactoring of the main application setup, and removal of several plugins. The most important changes involve updating dependencies in
package.json, refactoringsrc/app.jsto use the latestprobotsetup, and removing multiple plugins that are no longer needed.Note: I couldn't figure out how to run the bot locally to ensure it will start.
Fixes #205
Dependency Updates:
momentto version^2.30.1,moment-timezoneto^0.5.46,probotto^13.4.1, and added@octokit/restas a new dependency. (package.json: package.jsonL25-R37)jestto version^29.7.0andnockto^13.5.6. (package.json: package.jsonL25-R37)22.x. (package.json: package.jsonL58-R59)Application Setup Refactoring:
src/app.jsto use the latestProbotsetup, including new type definitions and updated initialization code. (src/app.js: [1] [2] [3]Plugin Removals:
auto-closerplugin entirely. (src/plugins/auto-closer/index.js: src/plugins/auto-closer/index.jsL1-L218)check-unit-testplugin entirely. (src/plugins/check-unit-test/index.js: src/plugins/check-unit-test/index.jsL1-L82)duplicate-commentsplugin entirely. (src/plugins/duplicate-comments/index.js: src/plugins/duplicate-comments/index.jsL1-L132)src/plugins/index.jsto reflect the removal of the aforementioned plugins. (src/plugins/index.js: src/plugins/index.jsL16-L21)Minor Refactoring:
commit-messageplugin for consistency with the newProbotsetup. (src/plugins/commit-message/index.js: [1] [2] [3] [4] [5] [6]