Skip to content

feat(setup-sentry): Add toggle to setup sentry gha #104459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hubertdeng123 wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −0
Draft

feat(setup-sentry): Add toggle to setup sentry gha #104459

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
920a68d
add toggle to setup sentry gha
hubertdeng123 Dec 5, 2025
ded4f85
add quotes
hubertdeng123 Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/actions/setup-sentry/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ inputs:
description: 'Mode to bring up by new devservices'
required: false
default: 'default'
toggle:
description: 'Dependency to toggle off '
Copy link
Member

@joshuarli joshuarli Dec 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be dependency to toggle to local to be explicit?

and then devservices toggle foo local

Copy link
Member Author

@hubertdeng123 hubertdeng123 Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it should

required: false

outputs:
matrix-instance-number:
Expand Down Expand Up @@ -124,6 +127,11 @@ runs:
# This is necessary to bring up devservices with appropriate sentry config
cd "$WORKDIR"

if [ "${{ inputs.toggle }}" != "" ]; then
echo "Toggling off ${{ inputs.toggle }}"
devservices toggle "${{ inputs.toggle }}"
fi

devservices up --mode ${{ inputs.mode }}

# have tests listen on the docker gateway ip so loopback can occur
Expand Down
Loading