Skip to content

Conversation

@PascalBourdier
Copy link

update method:

golangci-lint migrate
golangci-lint run --fix

and fix the last ones manually

update method:
```
golangci-lint migrate
golangci-lint run --fix
```

and fix the last ones manually
Copilot AI review requested due to automatic review settings December 1, 2025 18:43
Copilot finished reviewing on behalf of PascalBourdier December 1, 2025 18:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates golangci-lint from v1 to v2, applying automated linting fixes and migrating the configuration format. The changes align the codebase with modern Go conventions and golangci-lint v2 requirements.

  • Updates golangci-lint configuration to v2 format with separated linters and formatters sections
  • Standardizes error messages to follow Go conventions (lowercase start, no trailing periods)
  • Modernizes string operations by replacing strings.Replace(..., -1) with strings.ReplaceAll()

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
.golangci.yml Migrates configuration to v2 format, separates formatters from linters
.github/workflows/ci.yaml Updates golangci-lint-action to v9 and version to v2.6.2
testing/docker.go Lowercases error message starts (5 instances)
source/gitlab/gitlab.go Simplifies embedded struct field access
internal/cli/commands.go Lowercases error messages and improves punctuation
database/testing/testing.go Lowercases error message start
database/sqlserver/sqlserver.go Removes trailing period from error message
database/snowflake/snowflake.go Replaces strings.Replace with strings.ReplaceAll
database/redshift/redshift.go Replaces strings.Replace with strings.ReplaceAll
database/redshift/redshift_test.go Updates test code to use strings.ReplaceAll
database/postgres/postgres.go Lowercases error messages and uses strings.ReplaceAll
database/postgres/postgres_test.go Updates test code to use strings.ReplaceAll
database/pgx/v5/pgx.go Lowercases error messages and uses strings.ReplaceAll (2 locations)
database/pgx/v5/pgx_test.go Updates test code to use strings.ReplaceAll
database/pgx/pgx.go Lowercases error messages and uses strings.ReplaceAll (3 locations)
database/pgx/pgx_test.go Updates test code to use strings.ReplaceAll
database/mysql/mysql.go Lowercases error message start
database/clickhouse/clickhouse.go Replaces strings.Replace with strings.ReplaceAll
database/cassandra/cassandra.go Lowercases error message start

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coveralls
Copy link

Coverage Status

coverage: 54.432%. remained the same
when pulling c7ff14f on PascalBourdier:golangcilintv2
into 89e308c on golang-migrate:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants