clean up a bunch of unchecked casts using Class.cast() #11402
Conversation
|
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ All commit messages should start with a JIRA issue key matching pattern › This message was automatically generated. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| final SharedSessionContractImplementor session) throws SQLException { | ||
| //noinspection unchecked | ||
| nullSafeSet( st, (T) value, index, (WrapperOptions) session ); | ||
| final SharedSessionContractImplementor session) |
Check notice
Code scanning / CodeQL
Confusing overloading of methods Note
| } | ||
| if ( Integer.class.isAssignableFrom( type ) ) { | ||
| return (X) (Integer) Integer.parseInt( value ); | ||
| return type.cast( Integer.parseInt( value ) ); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException Note
| } | ||
| if ( Long.class.isAssignableFrom( type ) ) { | ||
| return (X) (Long) Long.parseLong( value ); | ||
| return type.cast( Long.parseLong( value ) ); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException Note
I don't know why we even need to be doing this. We deprecated that stuff. But we have one single test which is relying on this, so perhaps users are using it too.
| return wrapped; | ||
| } | ||
|
|
||
| private <X> T[] wrapObjectArray(X value, Object[] array, WrapperOptions options) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
and fix unchecked casts in the impl
this change exposed multiple bugs! 1. generic attributes declared by a mapped superclass where not being handled properly in HQL path expressions 2. getSubTypes() on EntityTypeImpl was broken (due, again, to use of unchecked cast!) causing problems in HQL
1 participant
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.