-
Notifications
You must be signed in to change notification settings - Fork 13.4k
fix(modal): allow interaction with parent content through sheet modals in child routes #30839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ShaneK
wants to merge
5
commits into
main
Choose a base branch
from
fix/sheet-modals
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+342
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e aren't allowing clicks through the background
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dc6d1ca to
7a814e9
Compare
7a814e9 to
f776b49
Compare
2 tasks
f776b49 to
34d3993
Compare
34d3993 to
3050ddf
Compare
…s showBackdrop=false in child routes
3050ddf to
cc6727a
Compare
a723344 to
ef60cf1
Compare
b662863 to
4454872
Compare
63d3985 to
38743ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
package: angular
@ionic/angular package
package: core
@ionic/core package
package: react
@ionic/react package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30700
What is the current behavior?
When a sheet modal with showBackdrop=false is rendered in a child route (nested ion-router-outlet), the parent content becomes non-interactive. Clicks on buttons or other interactive elements in the parent component are blocked, even though showBackdrop=false should allow background interaction.
Two separate issues contributed to this bug:
backdropBreakpoint: TheshouldLockRootlogic inoverlays.tsdidn't account forbackdropBreakpoint. Modals withbackdropBreakpoint > 0were still locking the root witharia-hidden, even though developers expect background interaction when the modal is below the backdrop breakpoint.ion-page) and its parention-router-outletremain in the DOM withposition: absolutecovering the viewport. Even after the modal is moved toion-appand haspointer-events: none, these wrapper elements block clicks to the parent page's content.This issue stems from #30563, which added root-locking behavior that didn't account for modals that allow background interaction. A partial fix in #30689 partially addressed
showBackdrop=falseandfocusTrap=false, but missedbackdropBreakpoint.What is the new behavior?
Sheet modals with showBackdrop=false or focusTrap=false now correctly allow interaction with parent content when the modal is in a child route.
Improvements:
Does this introduce a breaking change?
Other information
Dev build: