[JSON:API] Usage Improvements #57960
Open
+637
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
crynobone
changed the title
crynobone
commented
Nov 28, 2025
| ...(new Collection($this->filter($this->loadedRelationshipIdentifiers))) | ||
| ->map(function ($relation) { | ||
| return ! is_null($relation) ? $relation : ['data' => []]; | ||
| return ! is_null($relation) ? $relation : ['data' => null]; |
Member
Author
There was a problem hiding this comment.
https://jsonapi.org/format/#document-resource-object-linkage
data should be null for empty one-to-one relationship
crynobone
commented
Nov 28, 2025
| return ['id' => $uniqueKey[1], 'type' => $uniqueKey[0]]; | ||
| } | ||
| )]]]; | ||
| )]]; |
Member
Author
There was a problem hiding this comment.
fix one-to-one relationship to display as object instead of array.
crynobone
commented
Dec 3, 2025
crynobone
commented
Dec 3, 2025
| public function resolveResourceData(Request $request) | ||
| { | ||
| return $this->toAttributes($request); | ||
| } |
Member
Author
There was a problem hiding this comment.
@timacdonald I believe this should make it easier timacdonald/json-api forward compatible with a small change to TiMacDonald\JsonApi\JsonApiResource:
/**
* Resolve the resource data to an array.
*
* @param \Illuminate\Http\Request $request
* @return array
*/
public function resolveResourceData(Request $request)
{
return $this->toArray($request);
}* wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * Apply fixes from StyleCI * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * Apply fixes from StyleCI * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * Apply fixes from StyleCI * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * Apply fixes from StyleCI * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * Update src/Illuminate/Http/Resources/JsonApi/Concerns/ResolvesJsonApiElements.php --------- Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> Co-authored-by: StyleCI Bot <bot@styleci.io>
Removed debug dump from JSON API resource test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.