Skip to content

Conversation

@adityagesh
Copy link
Collaborator

No description provided.

@adityagesh adityagesh requested a review from LiliDeng as a code owner November 26, 2025 05:32

self._log.info("Successfully installed CUDA driver for Ubuntu")

def _install_cuda_debian(self) -> None:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to create a common method that works for both Debian and Ubuntu, avoiding duplicated code.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@adityagesh adityagesh force-pushed the aditya/gpu_regression_fix branch from b35f262 to cc89971 Compare November 26, 2025 07:14
@adityagesh
Copy link
Collaborator Author

Test is ongoing. The PR potentially impacts a lot of distro and variants.

@adityagesh adityagesh changed the title GPU: Add unsupported distro list, add NVIDIA GPU driver installation for Debian GPU: Add unsupported distro list, add NVIDIA GPU driver installation for Debian, SUSE Nov 26, 2025
@adityagesh adityagesh marked this pull request as draft November 26, 2025 11:36
@adityagesh adityagesh force-pushed the aditya/gpu_regression_fix branch 2 times, most recently from 81d8473 to 429a732 Compare November 27, 2025 10:03
Move logic to skip GPU cases based on distro
to case requirement
Checking of GPU support is not supposed to happen in
verification process. The is_supported checks are spread across
multiple functions for GPU. We need to gradually reduce this
incosistency
@adityagesh adityagesh force-pushed the aditya/gpu_regression_fix branch 3 times, most recently from ecf55d7 to 447f69c Compare December 3, 2025 06:26
@adityagesh adityagesh changed the title GPU: Add unsupported distro list, add NVIDIA GPU driver installation for Debian, SUSE GPU: Add unsupported distro list, add NVIDIA GPU driver installation for Debian Dec 3, 2025
@adityagesh adityagesh force-pushed the aditya/gpu_regression_fix branch from 447f69c to 6c67f3f Compare December 3, 2025 06:33
@adityagesh adityagesh marked this pull request as ready for review December 3, 2025 09:41
@adityagesh
Copy link
Collaborator Author

Not include changes for SUSE in this PR due to multiple issues faced while enabling SUSE. It may need more time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants