feat: show proxy environment variables in npm config list #8828
Conversation
MaxBlack-dev
force-pushed
the
fix/4170-show-proxy-env-vars
branch
2 times, most recently
from
3341cf4 to
f0b2737
Compare
lib/commands/config.js
Outdated
| const envVars = [] | ||
|
|
||
| // Show proxy-related environment variables if they're set | ||
| const proxyEnvVars = ['HTTP_PROXY', 'HTTPS_PROXY', 'NO_PROXY', 'http_proxy', 'https_proxy', 'no_proxy'] |
There was a problem hiding this comment.
This info should not live in the command. If there are variables that can affect config then @npmcli/config should own that list. Even if it's a manual list for now. Ideally that info would be coupled to the actual parsing of those but I don't think we have that kind of situation possible right now, since those are parsed explicitly in our fetching library and not parsed as config in npm.
There was a problem hiding this comment.
Good point! I've moved the list of proxy environment variables to @npmcli/config/lib/definitions/index.js as a new proxyEnv export. This keeps the environment variable list alongside other config-related constants like nerfDarts and shorthands.
The config command now imports and uses proxyEnv from @npmcli/config/lib/definitions instead of maintaining its own hardcoded list.
Fixes npm#4170 pm config list now displays proxy-related environment variables (HTTP_PROXY, HTTPS_PROXY, NO_PROXY and their lowercase equivalents) when they are set. This helps users understand what proxy settings are being used by npm. The environment variables are shown in a separate '; environment-related config' section before the system information (node version, npm version, etc.).
MaxBlack-dev
force-pushed
the
fix/4170-show-proxy-env-vars
branch
from
f0b2737 to
9c29072
Compare
2 participants
Fixes #4170
Description
This PR makes
pm config list display proxy-related environment variables when they are set.
Changes
Motivation
As reported in #4170,
pm config list was not showing environment variables like HTTP_PROXY, NOPROXY, etc., even though these variables affect how npm runs. This made it difficult for users to see what proxy settings their environment has and could lead to mistakes.
Testing
Manual testing confirms:
The new test case verifies that environment variables are displayed correctly.