Fix RestClient unnecessary bean creation in Spring Boot autoconfigura… #15560
+44
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion The RestClientBeanPostProcessor was creating a new RestClient bean every time it processed a bean, even when the OpenTelemetry interceptor was already present. This resulted in unnecessary bean creation and caused issues with proxy/delegate RestClient beans. Changes: - Modified RestClientBeanPostProcessor to track whether the interceptor was actually added during the mutation operation - Return the original bean instance if the interceptor is already present - Only create a new bean instance when the interceptor is actually added - Added test case to verify bean identity is preserved when interceptor exists This fix ensures that: 1. No unnecessary bean creation occurs when the interceptor is already present 2. Proxy/delegate RestClient beans work correctly 3. RestClient beans created with an injected RestClient.Builder that already has the interceptor configured are not unnecessarily mutated Fixes the issue where RestClient beans with the OTel interceptor already configured would still trigger mutation and new bean creation.
github-actions
bot
added
the
test native
Author
|
Please any reviewer to review this , and any more changes to be done regarding the issue just resolved. |
Member
|
Closing as there is already another PR for this: #15546 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tion
The RestClientBeanPostProcessor was creating a new RestClient bean every time it processed a bean, even when the OpenTelemetry interceptor was already present. This resulted in unnecessary bean creation and caused issues with proxy/delegate RestClient beans.
Changes:
This fix ensures that:
Fixes the issue where RestClient beans with the OTel interceptor already configured would still trigger mutation and new bean creation.