Modules/termios.c: stop using TC operations that need termio.h

[tpetazzoni]

Modules/termios.c makes use of TCGETA, TCSETA, TCSETAF and TCSETAW if they are defined. They are defined by kernel headers on a limited set of CPU architectures, but require the "struct termio" definition to exist, and this structure definition has been removed from glibc as of version 2.42.

Since these are seldomly used, we take the approach of just dropping support for those, in order to fix the following build issue:

./Modules/termios.c:1119:16: error: invalid application of 'sizeof' to incomplete type 'struct termio'
1119 | {"TCGETA", TCGETA},
| ^~~~~~
./Modules/termios.c:1131:16: error: invalid application of 'sizeof' to incomplete type 'struct termio'
1131 | {"TCSETA", TCSETA},
| ^~~~~~
./Modules/termios.c:1134:17: error: invalid application of 'sizeof' to incomplete type 'struct termio'
1134 | {"TCSETAF", TCSETAF},
| ^~~~~~~
./Modules/termios.c:1137:17: error: invalid application of 'sizeof' to incomplete type 'struct termio'
1137 | {"TCSETAW", TCSETAW},
| ^~~~~~~
make[1]: *** [Makefile:3403: Modules/termios.o] Error 1

This issue is observed at least on sparc64, but not on more "mainstream" CPU architectures, as they do not define TCGETA/TCSETA/TCSETAF/TCSETAW.

[python-cla-bot]

The following commit authors need to sign the Contributor License Agreement:

• thomas.petazzoni@bootlin.com

[picnixz]

Please:

• sign the CLA
• open an issue for this change
• change the fix: I think we should instead detect during configure whether those macros are correct or not.

[thesamesam]

This is actually a bug in linux-headers. We hit it in Gentoo and I sent patches upstream for the affected arches (https://bugs.gentoo.org/962600). The issue is that those types_are_ still declared, just unusable, for certain arches.

hppa is fixed already, alpha has the patch queued, sparc I've not had a reply for yet. But it will take a while for such fixes to propagate, so CPython may still wish to implement a workaround.