gh-142278: Add granular change detection for platforms in CI #142350
+148
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanFromIreland
requested review from
AA-Turner,
ezio-melotti and
hugovk
as code owners
hugovk
reviewed
Dec 6, 2025
Comment on lines
+730
to
+750
| ${{ | ||
| !fromJSON(needs.build-context.outputs.run-windows-tests) | ||
| && ' | ||
| build-windows, | ||
| ' | ||
| || '' | ||
| }} | ||
| ${{ | ||
| !fromJSON(needs.build-context.outputs.run-ci-fuzz) | ||
| && ' | ||
| cifuzz, | ||
| ' | ||
| || '' | ||
| }} | ||
| ${{ | ||
| !fromJSON(needs.build-context.outputs.run-macos) | ||
| && ' | ||
| build-macos, | ||
| ' | ||
| || '' | ||
| }} |
Member
There was a problem hiding this comment.
These check a single job, perhaps make them one-liners?
Suggested change
| ${{ | |
| !fromJSON(needs.build-context.outputs.run-windows-tests) | |
| && ' | |
| build-windows, | |
| ' | |
| || '' | |
| }} | |
| ${{ | |
| !fromJSON(needs.build-context.outputs.run-ci-fuzz) | |
| && ' | |
| cifuzz, | |
| ' | |
| || '' | |
| }} | |
| ${{ | |
| !fromJSON(needs.build-context.outputs.run-macos) | |
| && ' | |
| build-macos, | |
| ' | |
| || '' | |
| }} | |
| ${{ !fromJSON(needs.build-context.outputs.run-windows-tests) && 'build-windows,' || '' }} | |
| ${{ !fromJSON(needs.build-context.outputs.run-ci-fuzz) && 'cifuzz,' || '' }} | |
| ${{ !fromJSON(needs.build-context.outputs.run-macos) && 'build-macos,' || '' }} |
Plus for andoid/ios/wasi below?
| value: ${{ jobs.compute-changes.outputs.run-ios }} # bool | ||
| run-wasi: | ||
| description: Whether to run the WASI tests | ||
| value: ${{ jobs.compute-changes.outputs.run-wasi }} # bool |
Member
There was a problem hiding this comment.
This whole list of outputs doesn't have any special order and its getting long, let's alphabetise, it'll make it easier to find things.
| run-ubuntu: ${{ steps.changes.outputs.run-ubuntu }} | ||
| run-android: ${{ steps.changes.outputs.run-android }} | ||
| run-ios: ${{ steps.changes.outputs.run-ios }} | ||
| run-wasi: ${{ steps.changes.outputs.run-wasi }} |
Comment on lines
+48
to
+51
| MACOS_DIRS = frozenset({"Mac"}) | ||
| IOS_DIRS = frozenset({"Apple", "iOS"}) | ||
| ANDROID_DIRS = frozenset({"Android"}) | ||
| WASI_DIRS = frozenset({Path("Tools", "wasm")}) |
Member
There was a problem hiding this comment.
Suggested change
| MACOS_DIRS = frozenset({"Mac"}) | |
| IOS_DIRS = frozenset({"Apple", "iOS"}) | |
| ANDROID_DIRS = frozenset({"Android"}) | |
| WASI_DIRS = frozenset({Path("Tools", "wasm")}) | |
| ANDROID_DIRS = frozenset({"Android"}) | |
| IOS_DIRS = frozenset({"Apple", "iOS"}) | |
| MACOS_DIRS = frozenset({"Mac"}) | |
| WASI_DIRS = frozenset({Path("Tools", "wasm")}) |
| run_ubuntu: bool = False | ||
| run_android: bool = False | ||
| run_ios: bool = False | ||
| run_wasi: bool = False |
| return frozenset(map(Path, filter(None, map(str.strip, changed_files)))) | ||
|
|
||
|
|
||
| def is_platform_specific(file: Path) -> str | None: |
Member
There was a problem hiding this comment.
Let's rename this, because the is_ prefix makes me think it returns bool.
| run_windows_msi = False | ||
|
|
||
| platforms_changed = set() | ||
| has_non_plat_specific_change = False |
Member
There was a problem hiding this comment.
Suggested change
| has_non_plat_specific_change = False | |
| has_platform_specific_change = True |
| if file.parent == GITHUB_WORKFLOWS_PATH: | ||
| if file.name == "build.yml": | ||
| run_tests = run_ci_fuzz = True | ||
| run_tests = run_ci_fuzz = has_non_plat_specific_change = True |
Member
There was a problem hiding this comment.
Suggested change
| run_tests = run_ci_fuzz = has_non_plat_specific_change = True | |
| run_tests = run_ci_fuzz = True | |
| has_platform_specific_change = False |
| if platform is not None: | ||
| platforms_changed.add(platform) | ||
| else: | ||
| has_non_plat_specific_change = True |
Member
There was a problem hiding this comment.
Suggested change
| has_non_plat_specific_change = True | |
| has_platform_specific_change = False |
|
|
||
| # Check which platform specific tests to run | ||
| if run_tests: | ||
| if has_non_plat_specific_change or not platforms_changed: |
Member
There was a problem hiding this comment.
Suggested change
| if has_non_plat_specific_change or not platforms_changed: | |
| if not has_platform_specific_change or not platforms_changed: |
hugovk
added
needs backport to 3.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.