gh-140266: Fix empty platform in build-details.json when using --with-build-python #142375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
There are unrelated changes and I suspect that this has been made via LLM. In addition this does not address the configure issue which is suspicious. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gh-140266: Fix build-details platform handling for non-cross builds
Key changes:
Treat empty _PYTHON_HOST_PLATFORM the same as unset in sysconfig.get_platform().
Ensures non-cross builds with --with-build-python generate correct platform value (e.g. linux-x86_64) instead of empty string.
Adjusted test_traceback so the Windows-only test is skipped on non-Windows platforms.
All tests pass on Linux/WSL after the fix.
A NEWS entry has been added.