Make cargo all-features build --all --all-targets pass
#220
+27
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The benches modules were unconditionally importing from the configurator module, which is only available when at least one of the elf, pe, or bzimage features is enabled. This caused compilation failures when building with --no-default-features or other feature combinations that don't enable any loader features. Added appropriate #[cfg(any(feature = "..."))] guards to all benchmark modules and a no-op fallback benchmark function for when no configurator features are enabled. Fixes rust-vmm#215 Signed-off-by: pizzacat83 <17941141+pizzacat83@users.noreply.github.com>
pizzacat83
requested review from
ShadowCurse,
andreitraistaru,
rbradford,
roypat and
sameo
as code owners
Collaborator
|
Cool - can we add this to the CI configuration so that this doesn't regress? |
Add --all-targets flag to all custom build test commands to ensure benchmarks, tests, and examples are compiled in addition to the library. Signed-off-by: pizzacat83 <17941141+pizzacat83@users.noreply.github.com>
Author
|
Sure, I added Note that #213 (updating rust-vmm-ci) changes tests like |
rbradford
approved these changes
Dec 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Fixes #215
This PR fixes compilation failures when building with
--no-default-features.The benchmark modules were unconditionally importing from the
configuratormodule, which is only available whenany(feature = "elf", feature = "pe", feature = "bzimage").This PR adds appropriate
#[cfg(...)]guards to align the benchmark modules with the feature requirements of the code they use. When no features are enabled, the benchmark function falls back to no-op.Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.