Console Variable fix for TestPointCheckLib #918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConInDev, ConOutDev & ErrOutDev variables have list of device paths which have terminal console devices appended at the end. For only the user selected terminal type, the device path will have the necessary protocols installed at any point in time. TestPointCheckLib tries to discover these non existing terminal types and reports as an error. This patch fixes this by checking if the device path is a terminal type, and if so, then ignore the terminal node and only check for the existence of the parent path. Signed-off-by: Shankar C <shankar.c@amd.com>
shkrc
requested review from
ChaselChiu,
SaiChaganty and
nate-desimone
as code owners
Contributor
Author
|
@niruiyu requesting your reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConInDev, ConOutDev & ErrOutDev variables have list of device paths which have terminal console devices appended at the end. For only the user selected terminal type, the device path will have the necessary protocols installed at any point in time. TestPointCheckLib tries to discover these non existing terminal types and reports as an error. This patch fixes this by checking if the device path is a terminal type, and if so, then ignore the terminal node and only check for the existence of the parent path.