UefiCpuPkg/BaseRiscV64CpuTimerLib: Add constructor to initialize mTimeBase #11819
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a constructor function that calls GetPerformanceCounterProperties(NULL, NULL) to ensure mTimeBase is initialized during DXE phase, before virtual memory is enabled.
This fixes crashes on RISC-V platforms without fw_cfg device support (e.g., QEMU rvsp-ref) where Runtime Services may call GetPerformanceCounterProperties() before mTimeBase has been initialized. When virtual memory is then enabled, the uninitialized mTimeBase value causes HOB access to fail with a page fault.
Fixes: #11747
How This Was Tested
To boot a kernel that has enabled the EFI timer service for time retrieval using EDKII on the QEMU rvsp-ref Machine (or other boards without fw_cfg support).
Since the rvsp-ref board has not yet been merged into the QEMU mainline, you can test it through my personal repo:
https://github.com/zevorn/qemu/tree/rvsp-ref-v4
Integration Instructions
N/A