Revert broken codeql changes #11849
Revert broken codeql changes #11849
Conversation
This reverts commit 6d4fbc0. Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
This reverts commit 1097edb. Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
This reverts commit 2fd6884. Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
This reverts commit 901c4e3. Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
This reverts commit 8c92e6e. Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
This reverts commit 5214f93. Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
tianocore-assign-reviewers
bot
requested review from
dandanbi,
jiaxinwu,
lgao4 and
niruiyu
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (PlatformDefaultBootOptionValid && PcdGetBool (PcdPlatformRecoverySupport)) { | ||
| LoadOptions = EfiBootManagerGetLoadOptions (&LoadOptionCount, LoadOptionTypePlatformRecovery); | ||
| if ((LoadOptions != NULL) && (EfiBootManagerFindLoadOption (&PlatformDefaultBootOption, LoadOptions, LoadOptionCount) == -1)) { | ||
| if (EfiBootManagerFindLoadOption (&PlatformDefaultBootOption, LoadOptions, LoadOptionCount) == -1) { |
Check failure
Code scanning / CodeQL
Returned pointer not checked High
| ProcessLoadOptions (LoadOptions, LoadOptionCount); | ||
| EfiBootManagerFreeLoadOptions (LoadOptions, LoadOptionCount); | ||
| } | ||
| ProcessLoadOptions (LoadOptions, LoadOptionCount); |
Check failure
Code scanning / CodeQL
Returned pointer not checked High
| ProcessLoadOptions (LoadOptions, LoadOptionCount); | ||
| EfiBootManagerFreeLoadOptions (LoadOptions, LoadOptionCount); | ||
| } | ||
| ProcessLoadOptions (LoadOptions, LoadOptionCount); |
Check failure
Code scanning / CodeQL
Returned pointer not checked High
| if (PreviousMenuOption != NULL) { | ||
| *SkipValue = PreviousMenuOption->Skip - Rows; | ||
| } | ||
| *SkipValue = PreviousMenuOption->Skip - Rows; |
Check failure
Code scanning / CodeQL
Returned pointer not checked High
| RefreshKeyHelp (gFormData, SavedMenuOption->ThisTag, FALSE); | ||
| } | ||
|
|
||
| RefreshKeyHelp (gFormData, SavedMenuOption->ThisTag, FALSE); |
Check failure
Code scanning / CodeQL
Returned pointer not checked High
| CurrentExpression->TimeOut = ((EFI_IFR_WARNING_IF *)OpCodeData)->TimeOut; | ||
| CurrentExpression->Type = EFI_HII_EXPRESSION_WARNING_IF; | ||
| if (ParentStatement != NULL) { | ||
| InsertTailList (&ParentStatement->WarningListHead, &CurrentExpression->Link); |
Check failure
Code scanning / CodeQL
Returned pointer not checked High
| if (ParentStatement != NULL) { | ||
| InsertTailList (&ParentStatement->NestStatementList, &DisplayStatement->DisplayLink); | ||
| } | ||
| InsertTailList (&ParentStatement->NestStatementList, &DisplayStatement->DisplayLink); |
Check failure
Code scanning / CodeQL
Returned pointer not checked High
| } | ||
|
|
||
| NextElementBakup = NextRequestElement; | ||
| NextRequestElement = StrStr (RequestElement, ValueKey); |
Check failure
Code scanning / CodeQL
Returned pointer not checked High
| // | ||
| // Replace "&" with '\0'. | ||
| // | ||
| *NextRequestElement = L'\0'; |
Check failure
Code scanning / CodeQL
Returned pointer not checked High
| } else { | ||
| if (RespString && (Storage->Type == EFI_HII_VARSTORE_EFI_VARIABLE_BUFFER)) { | ||
| NextElementBakup = NextRequestElement; | ||
| NextRequestElement = StrStr (RequestElement, ValueKey); |
Check failure
Code scanning / CodeQL
Returned pointer not checked High
|
PR can not be merged due to conflict. Please rebase and resubmit |
1 participant
A recent series of CodeQL inspired patches introduced bugs and regressed the boot on some platforms.
Given that the author currently appears unavailable for addressing these issues, revert them so it can be revisited at a later time.