Notification Container: Make toast notifications announced by screen readers in Chrome. #21028
+64
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move screen reader live region from Shadow DOM to Light DOM (document.body) Chrome doesn't reliably detect ARIA live regions inside Shadow DOM - Use role="alert" with fresh elements for each announcement instead of updating text content of an existing live region - Fix invalid aria-role="true" attribute (was invalid HTML) - Fix missing backslash in unicode escape '\u00A0' The previous implementation had the live region nested 3 levels deep in Shadow DOM, which Safari handled but Chrome ignored. Creating a new alert element in Light DOM for each announcement is the most reliable method across browsers. Closes #14521 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
nielslyngsoe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
document.body) - Chrome doesn't reliably detect ARIA live regions inside Shadow DOMrole="alert"with fresh elements for each announcement instead of updating text content of an existing live regionaria-role="true"attribute (was invalid HTML)Root Cause
The previous implementation had the live region nested 3 levels deep in Shadow DOM:
→ shadow-root → → shadow-root → #sr-live
Chrome doesn't reliably detect ARIA live regions inside Shadow DOM, while Safari is more forgiving. Creating a new alert element in Light DOM for each announcement is the most reliable method across
browsers.
References
Test plan
🤖 Generated with Claude Code