Skip to content

[maintenance] make spelling corrections #3382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
icfaust wants to merge 35 commits into
base: main
Choose a base branch
from
Open

[maintenance] make spelling corrections #3382

icfaust wants to merge 35 commits into from

Conversation

@icfaust
Copy link
Contributor

@icfaust icfaust commented Oct 3, 2025

Description

Checklist:

Completeness and readability

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with updates and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least a summary table with measured data, if performance change is expected.
  • I have provided justification why performance and/or quality metrics have changed or why changes are not expected.
  • I have extended the benchmarking suite and provided a corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

icfaust added 30 commits October 3, 2025 23:55
@icfaust
Update MAINTAINERS.md
65d0357
@icfaust
Update README.md
d9344ce
@icfaust
Update makefile
d2ee05f
@icfaust
Update threading.h
5747ec4
@icfaust
Update service_topo.cpp
faeff75
@icfaust
Update service_daal_load_win_dynamic_lib.cpp
0ec4706
@icfaust
Update error_handling.cpp
516511f
@icfaust
Update error_handling.cpp
65c86c4
@icfaust
Update dll.rc
8317221
@icfaust
Update em_gmm_dense_default_batch_task.h
11b1dc4
@icfaust
Update cosdistance_batch_container.h
384b448
@icfaust
Update linear_model_train_qr_kernel.h
1374b26
@icfaust
Update linear_model_train_normeq_kernel.h
0726192
@icfaust
Update assoc_rules_apriori_kernel.h
2ce7b4e
@icfaust
Update kmeans_plusplus_init_impl.i
e4faaad
@icfaust
Update kmeans_lloyd_batch_impl.i
82e2aea
@icfaust
Update gbt_regression_train_container.h
30ddf99
@icfaust
Update gbt_classification_predict_dense_default_batch_impl.i
97d4b37
@icfaust
Update treeshap.cpp
aedfa02
@icfaust
Update gbt_train_updater.i
163e4f8
@icfaust
Update gbt_train_tree_builder.i
82be882
@icfaust
Update gbt_train_aux.i
85899e6
@icfaust
Update df_classification_train_dense_default_impl.i
8bbc185
@icfaust
Update dtrees_train_data_helper.i
72d8637
@icfaust
Update tsne_gradient_descent_impl.i
7630779
@icfaust
Update logitboost_train_kernel.h
0a4cdd7
@icfaust
Update logistic_loss_dense_default_batch_impl.i
2636d5d
@icfaust
Update qr_dense_default_pcl_impl.i
9a95b9b
@icfaust
Update cordistance_batch_container.h
7da0cdc
@icfaust
Update implicit_als_predict_ratings_dense_default_impl.i
64a3e30
david-cortes-intel
david-cortes-intel approved these changes Oct 6, 2025
View reviewed changes
Copy link
Contributor

@david-cortes-intel david-cortes-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the most part, but if this was created through some automated tool, it would be better to wait until this other PR is merged in order to avoid merge conflicts that might get hard to resolve:
#3304

@david-cortes-intel
Copy link
Contributor

david-cortes-intel commented Oct 6, 2025

From the CI, this is the file that needs linting:

cpp/daal/src/algorithms/kmeans/kmeans_lloyd_batch_impl.i

icfaust and others added 2 commits October 7, 2025 00:55
@icfaust
clang-formatting
e870c13
@icfaust @david-cortes-intel
Update cpp/daal/src/services/error_handling.cpp
cc6732f 
Co-authored-by: david-cortes-intel <david.cortes@intel.com>
@icfaust @david-cortes-intel
Update cpp/daal/src/algorithms/dtrees/forest/classification/df_classi…
5fb5092 
…fication_train_dense_default_impl.i

Co-authored-by: david-cortes-intel <david.cortes@intel.com>
@icfaust
Copy link
Contributor Author

icfaust commented Oct 7, 2025

Ill hold off on merging, and will split more changes into another PR.

@icfaust
Copy link
Contributor Author

icfaust commented Oct 10, 2025

/intelci: run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethanglaser ethanglaser ethanglaser approved these changes

@Alexandr-Solovev Alexandr-Solovev Alexandr-Solovev approved these changes

@david-cortes-intel david-cortes-intel david-cortes-intel approved these changes

@razdoburdin razdoburdin Awaiting requested review from razdoburdin razdoburdin is a code owner

@ahuber21 ahuber21 Awaiting requested review from ahuber21 ahuber21 is a code owner

@avolkov-intel avolkov-intel Awaiting requested review from avolkov-intel avolkov-intel is a code owner

@Alexsandruss Alexsandruss Awaiting requested review from Alexsandruss

@KateBlueSky KateBlueSky Awaiting requested review from KateBlueSky

@Vika-F Vika-F Awaiting requested review from Vika-F Vika-F is a code owner

@maria-Petrova maria-Petrova Awaiting requested review from maria-Petrova maria-Petrova is a code owner

@syakov-intel syakov-intel Awaiting requested review from syakov-intel syakov-intel is a code owner

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@icfaust @david-cortes-intel @ethanglaser @Alexandr-Solovev