Skip to content

Conversation

@Alexandr-Solovev
Copy link
Contributor

@Alexandr-Solovev Alexandr-Solovev commented Dec 4, 2025

Description

1. Static library linking rule

Added cleanup of temporary files after linking.
Now the static build removes the temp cache directory after $(LINK.STATIC).

2. Switching from copy to move

Replaced the static file copy operation with a move operation.
Instead of duplicating the built static library, it is now moved to the target directory.


Checklist:

Completeness and readability

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with updates and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least a summary table with measured data, if performance change is expected.
  • I have provided justification why performance and/or quality metrics have changed or why changes are not expected.
  • I have extended the benchmarking suite and provided a corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

@Alexandr-Solovev Alexandr-Solovev changed the title fixes for ci fixes for ci LinuxMakeDPCPP(avx2) Dec 4, 2025
@Alexandr-Solovev Alexandr-Solovev added the dependencies Pull requests that update a dependency file label Dec 4, 2025
@Alexandr-Solovev Alexandr-Solovev marked this pull request as ready for review December 4, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant