tests: benchdnn: graph: support validation for SDPA with non-contiguous strides in mask add #4398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rongzha1
approved these changes
Dec 1, 2025
dzarukin
reviewed
Dec 1, 2025
| , ctx_exe(ctx_exe) | ||
| , impl_filter(impl_filter) { | ||
| repro = set_repro_line(); // must be last in ctor to collect right info | ||
| } |
Contributor
There was a problem hiding this comment.
Please extend the existing one instead, it will require just one modification with it.
It would be also nice if binary driver gets this capability, too, through its interface.
Contributor
Author
There was a problem hiding this comment.
Thanks for the suggestion, updated! Could you pls take another look?
with non-contiguous strides in mask add
ElaineBao
force-pushed
the
yixin/support_non_dense_strides
branch
from
0bb3060 to
9902832
Compare
github-actions
bot
added
the
documentation
TaoLv
reviewed
Dec 5, 2025
|
|
||
| logical_tensor::dims src_strides = base_op_ref.in_lts_[0].stride_; | ||
| logical_tensor::dims wei_strides = base_op_ref.in_lts_[1].stride_; | ||
| const logical_tensor::dims &dst_strides = base_op_ref.out_lts_[0].stride_; |
Contributor
There was a problem hiding this comment.
Is it on purpose to only have dst_strides in const ref, while copy for src_strides and wei_strides?
| --reset --op-attrs=0:transpose_b:1 --case=complex_fusion/mha/gemma2-bf16-f32.json | ||
|
|
||
| # sdpa with non-contiguous strides in mask add | ||
| --reset --in-shapes=5:1x1x384x384*147840x147840x385x1 --case=complex_fusion/mha/sdpa-plain-simplified-f16-f32.json |
Contributor
There was a problem hiding this comment.
Just for my curiosity, could you please paste here the verbose logs of this case? Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MFDNN-14395 reported a correctness issue for SDPA when the mask add is having a non-contiguous strides (shape: 1x1x1024x1024, strides:1049600x1049600x1025x1). Currently benchdnn graph doesn't support such case's validation (segfault). This PR aims to fix this.