Skip to content

Conversation

@edison1105
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings December 6, 2025 13:46
@coderabbitai
Copy link

coderabbitai bot commented Dec 6, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch edison/fix/forSlot

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Dec 6, 2025

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 85.2 kB 29.9 kB 26.4 kB
runtime-dom.global.prod.js 108 kB 40.5 kB 36.5 kB
vue.global.prod.js 166 kB 60.5 kB 53.9 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 48.2 kB 18.8 kB 17.2 kB
createApp 57.2 kB 22 kB 20.1 kB
createApp + vaporInteropPlugin 96 kB (+75 B) 35.4 kB (+5 B) 31.9 kB (-27 B)
createVaporApp 42 kB (+1.08 kB) 15.5 kB (+272 B) 14.1 kB (+255 B)
createSSRApp 61.6 kB 23.8 kB 21.7 kB
defineCustomElement 63.3 kB 23.8 kB 21.7 kB
overall 71.9 kB 27.2 kB 24.8 kB

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 6, 2025

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@14176

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@14176

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@14176

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@14176

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@14176

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@14176

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@14176

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@14176

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@14176

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@14176

@vue/shared

npm i https://pkg.pr.new/@vue/shared@14176

vue

npm i https://pkg.pr.new/vue@14176

@vue/compat

npm i https://pkg.pr.new/@vue/compat@14176

commit: f96ba5f

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes dynamic slot rendering performance by caching the results of dynamic slot functions using Vue's computed API, preventing redundant function calls within the same render cycle.

  • Adds a caching mechanism using computed for dynamic slot functions
  • Introduces the resolveDynamicSlot helper to manage cache lifecycle
  • Reorganizes tests into a dedicated createForSlots describe block with comprehensive caching behavior tests

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/runtime-vapor/src/componentSlots.ts Adds _cache property to DynamicSlotFn type, implements resolveDynamicSlot helper function, and updates call sites to use the caching mechanism
packages/runtime-vapor/tests/componentSlots.spec.ts Reorganizes existing test into createForSlots describe block and adds three new tests verifying caching behavior, reactivity updates, and correct rendering

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants