Skip to content

Add a Note for Test Suite Conformance #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
YoucTagh wants to merge 2 commits into
base: gh-pages
Choose a base branch
from
Open

Add a Note for Test Suite Conformance #595

YoucTagh wants to merge 2 commits into from

Conversation

@YoucTagh
Copy link
Contributor

@YoucTagh YoucTagh commented Oct 3, 2025

HolgerKnublauch
HolgerKnublauch reviewed Oct 3, 2025
View reviewed changes
Copy link
Contributor

@HolgerKnublauch HolgerKnublauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test suite will also cover SPARQL, node expr etc. So would it be better to move this block to an included shared file, or the overview?

@YoucTagh YoucTagh mentioned this pull request Oct 3, 2025
Open
@YoucTagh YoucTagh added Core For SHACL 1.2 Core spec SPARQL For SHACL 1.2 SPARQL extensions spec Node Expressions For SHACL 1.2 Node Expressions labels Oct 6, 2025
@ajnelson-nist
Copy link
Contributor

ajnelson-nist commented Nov 14, 2025

The test suite will also cover SPARQL, node expr etc. So would it be better to move this block to an included shared file, or the overview?

As this patch is written, the only described tests are for Core. I'd support making the patch's statement a bit more general and moving the remark to an included shared file.

HolgerKnublauch
HolgerKnublauch reviewed Dec 4, 2025
View reviewed changes
shacl12-common/specifications.html

<p class="note">
Implementers can partially check their level of conformance with the above specifications by successfully passing
the test cases of the <a href="https://w3c.github.io/data-shapes/data-shapes-test-suite/">SHACL 1.2 test suite</a>.
Copy link
Contributor

@HolgerKnublauch HolgerKnublauch Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That link is for the 1.0 tests. We still need to create a clone of that, which uses https://github.com/w3c/data-shapes/tree/gh-pages/shacl12-test-suite as its tests and has no implementation reports yet.

Copy link
Contributor Author

@YoucTagh YoucTagh Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the clone is ready, I will update the link and complete the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HolgerKnublauch HolgerKnublauch HolgerKnublauch left review comments

@ajnelson-nist ajnelson-nist ajnelson-nist approved these changes

@bergos bergos Awaiting requested review from bergos

@jeswr jeswr Awaiting requested review from jeswr

Assignees

No one assigned

Labels

Core For SHACL 1.2 Core spec Node Expressions For SHACL 1.2 Node Expressions SPARQL For SHACL 1.2 SPARQL extensions spec

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a Note About the Test Suite Conformance Check

4 participants

@YoucTagh @ajnelson-nist @HolgerKnublauch